-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new message header feature in ISO specs seem to not play well with children rows #59
Comments
Hi, I will take a look at this, but a couple of questions -
I think what you are looking for is - Define a set of fields as header fields and only some of those will account for being the header? In your case, you want to parse the first 46 (header) + 4 (for message type) and only consider 4 bytes of the message type for selection ( i.e. in header_match) Is so, I'll consider that as a enhancement :) |
Just to reply to your questions:
In my use case, there is a message header (fixed as 46 bytes with many fix size subfield inside), which is separate to message type (4 bytes), so it's a pretty complicated case. I could probably have just hard coded the header as 46 bytes and ignore all the details to make it work. I think it's probably an uncommon need for ppl to go to this level of granuality. |
Closing this and tracking via #68 |
Hi, I have been trying out v0.10.0, and the experience is very good. It fixed a few bugs I experienced with, and I noticed you introduced message header concept into the specs.
https://github.com/rkbalgi/isosim/blob/master/test/testdata/specs/iso_specs.yaml
However, when I tried the message header spec, it did not seem to work nicely.
Below is a workable spec.
I tried to transform this same spec to use message header (ie. moving Message Header into header_fields), but when I try to send the same message over, it could not handle this message properly.
Since I can work around it, I am ok with this issue. I am guessing this is because
header_fields
feature is still early in development, but I'll report it anyway for awareness.The text was updated successfully, but these errors were encountered: