Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rperp metric and max_rpar for 3-point statistics #177

Open
caspervedder opened this issue Dec 6, 2024 · 3 comments
Open

Rperp metric and max_rpar for 3-point statistics #177

caspervedder opened this issue Dec 6, 2024 · 3 comments

Comments

@caspervedder
Copy link

Hi Mike,

First of all, thank you for making your code public!

I was wondering if it would be possible to have some sort of 'projected/transverse' metric which could be used in combination with a restriction on the line-of-sight separation of the points for the 3-point correlation functions (in my case, GGG specifically). This would be similar to the Rperp metric for 2-point correlation functions (discussed in Issue #17).

I guess this can be made quite complicated as there are 3 parallel coordinates for the three points of the triangle. However, a simple restriction would already be very helpful for me. For example, if we order the parallel distances: r_par1 < r_par2 < r_par3, a helpful restriction would be |rpar3 - rpar1| < Pi.

In general, I can imagine there might be several other options that could be relevant for different purposes though, specifically if the cross-correlations NNG and NGG are added.

Best,

Casper

@caspervedder caspervedder changed the title Rperp metric and min_rpar/max_rpar for 3-point statistics Rperp metric and max_rpar for 3-point statistics Dec 6, 2024
@rmjarvis
Copy link
Owner

rmjarvis commented Dec 6, 2024

The Rperp metric should already been enabled for 3pt calculations. But you're correct that it's not currently possible to put restrictions on r_par combinations. I'll think about how to implement this.

@caspervedder
Copy link
Author

caspervedder commented Dec 7, 2024

Thank you! As for the Rperp metric, I seem to be missing something here. If I make a very simple GGGcorrelation() object with metric = 'Rperp', I get the following error:

Scherm­afbeelding 2024-12-07 om 10 39 22

This seems to match the documentation (https://rmjarvis.github.io/TreeCorr/_build/html/correlation3.html):

Scherm­afbeelding 2024-12-07 om 10 43 53

Edit: if I add the metric in the process function, like ggg.process(cat, metric = 'Rperp'), it does not give this error. (although it does return only 0's, but this could very well be due to other reasons, it also gives a failed assert output.)

@rmjarvis
Copy link
Owner

rmjarvis commented Dec 7, 2024

Oh, you're right. Sorry, I forgot that 3pt limited to that. I think it should be easy to enable all the metrics for 3pt. I can't remember now if there was a good reason that I limited to those three, but I don't think it should be a fundamental issue. The rpar limits will be a bit more work though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants