-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] CBF parser throwing exceptions on KI171, KI209 and KI230 #57
Comments
KI171 is a simple len check |
Hi, nice to hear from you again. Unfortunately, I currently have other projects going on, so I have very little time to devote to fixing these kind of bugs with CBFParser. The panics tell you the line number and source file where the error occured (Run with I suppose you can also try out CaesarSuite to see if that parses them correctly... |
Hi, Of course, I know that. I have modified them locally, for my purpose it was fine to 0 those values. I wrote to bring it to your attention, because the error is thrown as there is an expectation, in your code, for a value that isn't there (no can and no lin id's are found), so you can decide what will work for your purpose. If 0 is OK for your purpose too, or until you will want to look into it deeper, I can of course submit a PR, so at least the json is correctly generated. |
CBF parser is encountering problems on several cbf files for several ecus
I know there can be multiple versions of one specific cbf file, so I have tried multiple ones, for the same ecu, they all gave similar exceptions, so it should be possible to reproduce these bugs with any of the ecu's cbf files.
KI171
![image](https://user-images.githubusercontent.com/23619312/178141220-d7376968-4d50-4637-8b12-cc13a92b1263.png)
KI209 and KI230
![image](https://user-images.githubusercontent.com/23619312/178141255-92d35cbf-ac05-4e0c-83c4-16dc2fe177bc.png)
The text was updated successfully, but these errors were encountered: