Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] socket can support #7

Open
romainreignier opened this issue Jan 25, 2021 · 5 comments
Open

[FEATURE] socket can support #7

romainreignier opened this issue Jan 25, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@romainreignier
Copy link

Hi!

Thanks for this project that looks promising.

I know nothing about J2534 but this seems interesting.

I was wondering if the Linux CAN API socket can could be used in order to use any CAN adapter already compatible with Linux?

That would mean to port the J2534 part of the MacchinaM2 firmware into a new driver I think.

Is your feature request related to a problem? Please describe.
Use other CAN adapters, already compatible with Linux.

Describe the solution you'd like
A new OVD driver using Linux socket can.

I might try to dig into it so any pointer is welcomed.

@romainreignier romainreignier added the enhancement New feature or request label Jan 25, 2021
@rnd-ash
Copy link
Owner

rnd-ash commented Jan 25, 2021

Hi,

That is something I do wish to add at a later date. However currently I am too busy, so it'll have to wait until summer.

As for the 'how', socket can could be implemented by creating another struct which inherits the COMM_API trait, however I'm not sure how to send iso-tp payloads using socket CAN as of yet

@romainreignier
Copy link
Author

ISO TP support has recently been added to the Linux kernel with this commit. And now available in the kernel 5.10.

@romainreignier
Copy link
Author

For reference, older kernels can use this out-of-tree module: https://github.com/hartkopp/can-isotp

@rnd-ash
Copy link
Owner

rnd-ash commented Jan 26, 2021

I found these 2 crates:
https://docs.rs/socketcan-isotp/0.1.1/socketcan_isotp/
https://docs.rs/socketcan/1.7.0/socketcan/

These should make implementing this easy

@rnd-ash rnd-ash pinned this issue Jan 26, 2021
@rnd-ash rnd-ash added the will fix in summer Features that will be added to OVD only after I graduate (Summer) label Jan 26, 2021
@rnd-ash rnd-ash self-assigned this Feb 11, 2021
@rnd-ash
Copy link
Owner

rnd-ash commented Mar 24, 2021

Hi, 775a876 should add beta implementation of SocketCAN to OVD!

Appreciate some feedback from testers

@rnd-ash rnd-ash removed the will fix in summer Features that will be added to OVD only after I graduate (Summer) label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants