Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup hook fired at the beginning instead of at the end when using nested states #2146

Open
teksuo opened this issue Jun 2, 2022 · 0 comments

Comments

@teksuo
Copy link

teksuo commented Jun 2, 2022

Operating system

Ubuntu 22 & Manjaro

Helmfile Version

0.144.0

Helm Version

3.9.0

Bug description

I have a helmfile with a global "cleanup" hook and a "postsync" and "postuninstall" hook per-release. Everything works like a charm for both "sync" and "destroy" commands and the "cleanup" hook is always executed after all the releases have been processed.

However, when I start using nested states, the global "cleanup" hook for the "destroy" command gets executed at the beginning of the process, right after logging into the registry.

I honestly don't understand this behavior and I don't see it documented anywhere.

Any insight will be welcome,

Thanks in advance

Steps to reproduce

https://github.com/teksuo/helmfile-nested-hook-bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant