Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all device created by plugins can specify their YARP device instance name to be used by gazebo_yarp_robotinterface #535

Open
6 of 10 tasks
traversaro opened this issue Feb 11, 2021 · 2 comments

Comments

@traversaro
Copy link
Member

traversaro commented Feb 11, 2021

#532 added a gazebo_yarp_robotinterface. However, for YARP devices to be available to be connected to yarp device instantiated by the robotinterface plugin, it is necessary that the plugin support specifying the "YARP device instance name" of the created YARP devices.

The plugin that support doing that are listed in https://github.com/robotology/gazebo-yarp-plugins/pull/532/files#diff-016af8ed33c29358106ec0e48301e53602fc63ce5be3b985e45c73675367e49eR70, but this does not cover all plugins this at the moment does not include useful plugin such as gazebo_yarp_imu or gazebo_imu_forcetorque (these were covered thanks to @Nicogene and @GrmanRodriguez).

Definition of done: all the plugin can specify the the YARP device instance name of the YARP device that they create, so that this device can be attached to devices instantiate by gazebo_yarp_robotinterface .

Devices:

  • gazebo_yarp_imu
  • gazebo_imu_forcetorque
  • gazebo_yarp_controlboard
  • gazebo_yarp_depthcamera
  • gazebo_yarp_lasersensor
  • gazebo_yarp_multicamera
  • gazebo_yarp_fakecontrolboard (probalby not necessary as now with gazebo_yarp_controlboard we can use fakeMotionControl device from YARP, see Deprecate gazebo_yarp_fakecontrolboard #587)
  • gazebo_yarp_inertialmtb
  • gazebo_yarp_inertialmtbPart
  • gazebo_yarp_maissensor
@Nicogene
Copy link
Member

Thanks to #584 and #583 the support has been extended also to gazebo_imu and gazebo_forcetorque

@traversaro
Copy link
Member Author

Thanks @Nicogene and @GrmanRodriguez ! Probably it is a bit helpful to have a recap on the devices migrated and the one still to migrate, I have added one to the top comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants