-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how we handle dynamic properties #774
Comments
I've tried to make the purpose of If it is, the class docstring of |
That's fine with me. Thanks! |
Same — this is really for anyone wanting to implement fontParts into their app/objects/etc, to make it clear what the logic is. |
I see. On second thought, how well and where is the private/public method structure documented? Perhaps it makes sense to keep these parts of the documentation in the same place? |
It could go somewhere on here. It could say that the |
We have
_get/set_base_something
and_get/set_something
for a reason (below). That reasoning should be in the documentation somewhere.Reasoning from @typesupply:
The _get_base_something method calls the environment implementation _get_something. It then validates/normalizes the returned value before sending the value to the scripter.
Likewise, _set_base_something validates and normalizes the value from the scripter before passing it to the environment implementation _set_soemthing.
This makes sure that the scripter and the environment implementations don’t have to do any validation or normalization.
The text was updated successfully, but these errors were encountered: