Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional multi parameter for Prometheus is concat on one parameter #296

Open
korentzari opened this issue Dec 8, 2023 · 0 comments
Open

Comments

@korentzari
Copy link

Hello Rocket Pool Developers,

I'm encountering an issue while trying to add two additional parameters to Prometheus (--storage.tsdb.retention.time=2y and --web.external-url=/prometheus2). The problem arises because Prometheus seems to interpret "--storage.tsdb.retention.time=2y --web.external-url=/prometheus2" as a single parameter, which prevents it from functioning correctly.

Temporary Solution:
As a workaround, I've added a parameter in the template. However, this solution is not ideal since it gets overwritten with each new version release.

Suggested Fix:
I would like to discuss a more permanent solution to this issue, possibly by modifying the way Rocket Pool handles Prometheus parameters to ensure they are recognized correctly.

Steps to Reproduce:

  1. Attempt to add --storage.tsdb.retention.time=2y --web.external-url=/prometheus2 to Prometheus extra parameter in the current Rocket Pool setup.
  2. Observe that Prometheus treats these two parameters as a single parameter.

Any assistance or guidance on resolving this issue would be greatly appreciated.

Thank you for your time and consideration.

@korentzari korentzari changed the title ADDITIONAL MULTI PARAMETER FOR PROMETHEUS IS CONCAT ON ONE PARAMETER Additional multi parameter for Prometheus is concat on one parameter Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant