NodeMetricsPort and WatchtowerMetricsPort are ignored

[jakubgs]

It appears that both WatchtowerMetricsPort and NodeMetricsPort settings are ignored by the nodes:

smartnode/shared/services/config/rocket-pool-config.go

Lines 81 to 83 in 4969a80

	NodeMetricsPort config.Parameter `yaml:"nodeMetricsPort,omitempty"`
	ExporterMetricsPort config.Parameter `yaml:"exporterMetricsPort,omitempty"`
	WatchtowerMetricsPort config.Parameter `yaml:"watchtowerMetricsPort,omitempty"`

And ExporterMetricsPort probably also.

Based on reading the code it appears the value for smartnode metrics port and address comes from CLI context:

smartnode/rocketpool/node/metrics-exporter.go

Line 17 in 4969a80

func runMetricsServer(c *cli.Context, logger log.ColorLogger, stateLocker *collectors.StateLocker) error {

smartnode/rocketpool/node/metrics-exporter.go

Lines 95 to 96 in 4969a80

	metricsAddress := c.GlobalString("metricsAddress")
	metricsPort := c.GlobalUint("metricsPort")

Which as far as I can tell does not include settings from user-settings.yml file. The same goes for watchtower:

smartnode/rocketpool/watchtower/metrics-exporter.go

Line 17 in 4969a80

func runMetricsServer(c *cli.Context, logger log.ColorLogger, scrubCollector *collectors.ScrubCollector, bondReductionCollector *collectors.BondReductionCollector, soloMigrationCollector *collectors.SoloMigrationCollector) error {

smartnode/rocketpool/watchtower/metrics-exporter.go

Lines 42 to 43 in 4969a80

	metricsAddress := c.GlobalString("metricsAddress")
	metricsPort := c.GlobalUint("metricsPort")

I base this off of the fact that urfave/cli provides the GlobalString() method, which to me excludes the possibility that the configurations are merged.

Also, the metrics ports settings are defined using your own type for parameters:

smartnode/shared/services/config/rocket-pool-config.go

Lines 427 to 429 in 4969a80

	WatchtowerMetricsPort: config.Parameter{
	ID: "watchtowerMetricsPort",
	Name: "Watchtower Metrics Port",

smartnode/shared/types/config/parameter.go

Lines 10 to 11 in 4969a80

	// A parameter that can be configured by the user
	type Parameter struct {

Which as far as I can tell is not merged with CLI flags.

Based on this I conclude that both of these settings in user config file are not used.