Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It won't work using other open/close tags #31

Open
nriesco opened this issue May 14, 2017 · 6 comments
Open

It won't work using other open/close tags #31

nriesco opened this issue May 14, 2017 · 6 comments
Labels

Comments

@nriesco
Copy link

nriesco commented May 14, 2017

I haven't been able to generate anything using alternative open/close tags.

I have this .rock/rock.json config file:

{
  "tokens": {
    "open": "[[",
    "close": "]]"
  }
}

And after executingrock ./output --config ./template/.rock/rock.json -r ./template

My old file [[PACKAGE]].js will be now .js and there is no prompt for the PACKAGE variable value.

@nriesco
Copy link
Author

nriesco commented May 14, 2017

By the way the reason I need to use another open/close tags is because my files are mainly mustache files.

@RyanZim RyanZim added the bug label May 15, 2017
@RyanZim
Copy link
Member

RyanZim commented May 15, 2017

Confirmed. I've gotta look into this as soon as I can.

@nriesco
Copy link
Author

nriesco commented May 15, 2017

Thanks @RyanZim I found a workaround, and found the bug:

I'm using {{{ and }}} but in order to make it work I have to manually change it in my node_modules/rock/lib/rock.js file. So I guess it's not just choosing [[ what generated an error but also that it won't really use another open/close pair values.

Still, using {{{ works better for my app, looks more like stache files.

@RyanZim
Copy link
Member

RyanZim commented May 15, 2017

@nriesco You should be able to set custom tags in .rock/rock.json without changing rock's code.

@RyanZim
Copy link
Member

RyanZim commented May 15, 2017

I think I found the bug, the problem is that we aren't tweezing the filenames; I'll get a patch ASAP

@RyanZim
Copy link
Member

RyanZim commented May 16, 2017

@nriesco Try using the bugfix branch (npm install rocktemplates/rock#bugfix) I think I've got this bug fixed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants