From 8a11bcfab6582fec81124524ff26c4ec60e3222c Mon Sep 17 00:00:00 2001 From: Roman Chyla Date: Fri, 11 Mar 2022 15:58:40 -0500 Subject: [PATCH] feat: added krivoduski into unittests --- .../java/org/apache/solr/analysis/author/AuthorUtils.java | 2 +- .../solr/analysis/author/TestAdsabsTypeAuthorParsing.java | 5 +++++ .../analysis/author/TestAuthorTransliterationFilter.java | 1 + .../org/apache/solr/analysis/author/TestAuthorUtils.java | 1 + 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/contrib/adsabs/src/java/org/apache/solr/analysis/author/AuthorUtils.java b/contrib/adsabs/src/java/org/apache/solr/analysis/author/AuthorUtils.java index 40d31c7a5..41b9d111e 100644 --- a/contrib/adsabs/src/java/org/apache/solr/analysis/author/AuthorUtils.java +++ b/contrib/adsabs/src/java/org/apache/solr/analysis/author/AuthorUtils.java @@ -126,7 +126,7 @@ public static ArrayList getAsciiTransliteratedVariants(String a) { } // handle russian name stuff - HashSet transRus = transliterateRussianNames(synonyms); + HashSet transRus = transliterateRussianNames(synonyms ); synonyms.addAll(transRus); // apostrophes are now preserved in the index diff --git a/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAdsabsTypeAuthorParsing.java b/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAdsabsTypeAuthorParsing.java index 351da3843..ff3cd8ac6 100644 --- a/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAdsabsTypeAuthorParsing.java +++ b/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAdsabsTypeAuthorParsing.java @@ -372,6 +372,11 @@ public void xtestX() throws Exception { public void testAuthorParsingUseCases() throws Exception { + testAuthorQuery("\"krivodubski, v\"", + "", + "//*[@numFound='0']" + ); + assertQueryEquals(req("q", "author:\"van dok*, h\""), "author:van dok*, h", WildcardQuery.class); assertQ(req("q", "author:\"van dok*, h\""), "//*[@numFound='1']", diff --git a/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorTransliterationFilter.java b/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorTransliterationFilter.java index f7c223beb..926d349be 100644 --- a/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorTransliterationFilter.java +++ b/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorTransliterationFilter.java @@ -42,6 +42,7 @@ public void testAccents() throws Exception { checkIt("Duprè", "Duprè", "Dupre,"); // Dupre\\xcc\\x80 checkIt("\u0141", "Ł", "L,"); checkIt("Mendigutıa", "Mendigutıa", "Mendigutia,"); + checkIt("krivodubski, v", "krivodubski, v", "krivodubskyi, v", "krivodubsky, v", "krivodubskij, v", "krivodubskiy, v", "krivodubskii, v" ); } diff --git a/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorUtils.java b/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorUtils.java index 8edb99e40..10f124e35 100644 --- a/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorUtils.java +++ b/contrib/adsabs/src/test/org/apache/solr/analysis/author/TestAuthorUtils.java @@ -77,6 +77,7 @@ public void testTransliterations() { check("FOOVI, BAR", "FOOVYI, BAR", "FOOVII, BAR", "FOOVY, BAR", "FOOVIY, BAR", "FOOVIJ, BAR"); check("FOO, YURI", "FOO, IURI"); check("FOO, IAGNI", "FOO, YAGNI"); + check("krivodubski, v", "krivodubskii, v", "krivodubskij, v", "krivodubskiy, v", "krivodubsky, v", "krivodubskyi, v"); } public void testTransRussianNames() {