Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing --smtp option to ronin unescape #201

Open
postmodern opened this issue Jun 8, 2024 · 4 comments
Open

Add missing --smtp option to ronin unescape #201

postmodern opened this issue Jun 8, 2024 · 4 comments
Labels
command-option A command option feature New Feature good first issue Good first issue help-wanted Extra attention is needed
Milestone
2.2.0

Comments

@postmodern
Copy link
Member

The ronin unescape command is missing the --smtp option.
@postmodern postmodern added feature New Feature command-option A command option help-wanted Extra attention is needed good first issue Good first issue labels Jun 8, 2024
@zzJZzz
Copy link

zzJZzz commented Jul 5, 2024

Hey. Great work with Ronin. I'd be glad to work on this issue.

@postmodern
Copy link
Member Author

@zzJZzz feel free to send a PR for this. While we're in the middle of beta-testing Ronin 2.1.0, I could still release a 2.0.6 bug fix release and rebase the 2.1.0 branch so the next 2.1.0.rc has the missing option included as well.

@postmodern
Copy link
Member Author

postmodern commented Aug 1, 2024 •
edited
Loading

@zzJZzz I have now added String#smtp_encode, String#smtp_decode, String#smtp_escape, and String#smtp_unescape methods that are just aliases to the String#quoted_printable_* methods (email message bodies are encoded using Quoted Printable encoding, so "SMTP encoding" = Quoted Printable). I have also created a new 2.2.0 branch which bundles in the ronin-support 1.2.0 branch.

@postmodern postmodern added this to the 2.2.0 milestone Aug 16, 2024
@postmodern
Copy link
Member Author

Moving this issue to the 2.2.0 milestone, since it requires ronin-support 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
command-option A command option feature New Feature good first issue Good first issue help-wanted Extra attention is needed
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@postmodern @zzJZzz