Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adventurer 4 format #17

Open
DanielO opened this issue Sep 25, 2022 · 3 comments
Open

Adventurer 4 format #17

DanielO opened this issue Sep 25, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@DanielO
Copy link

DanielO commented Sep 25, 2022

Hi,
I didn't notice this plugin existed so I wrote my own but didn't get around to publish it yet.
One thing mine does is create a higher resolution PNG image (320x320) - not sure if you are interested in adding it.

The code is at https://github.com/DanielO/GXCodeWriter/blob/main/GXCodeWriter.py if you want to take a look.

(I'm happy to dual license it etc..)

@ronoaldo ronoaldo added enhancement New feature or request help wanted Extra attention is needed labels Sep 26, 2022
@ronoaldo ronoaldo self-assigned this Sep 26, 2022
@ronoaldo
Copy link
Owner

Hi Daniel! Yeah, the package was missing from the Marketplace for a while after Cura 5 release. Thanks to #15 and after I managed to pass the publish step it should be working fine.

Your suggestion seems doable with little effort indeed. Do we have a printer profile available in Cura for the Adventurer already? If we do, I can detect the size/format based on that. Otherwise, we can do a Settings Toggle for the GXWriter plugin based on your code. My implementation is encapsuled into this module, and I guess it could be extended to support a larger preview image in PNG format: https://github.com/ronoaldo/FlashforgeFinderIntegration/blob/master/plugins/GXWriter/gx.py

Regarding license, I'll check but as your work is currently BSD 2-clause and mine was GPL-3, I guess both could be distributed without issues.

@DanielO
Copy link
Author

DanielO commented Sep 27, 2022

I don't think there is a printer profile yet - I am still tuning mine.
I wonder if the older printers would ignore the PNG - it is implemented in the format separately to the BMP.
The header has 3 32 bit offsets and it looks like the older format doesn't use the second one but the new one does - that is where the PNG lives.
I created a file with my plugin:
https://www.dons.net.au/~darius/xyzCalibration_cube.gx

Does it work OK on your printer? (eg the LCD screen preview)

@davidt94
Copy link

davidt94 commented Feb 1, 2023

Thank you both for the work on this. Was anything done about implementing Daniels solution?

thank you!

@ronoaldo ronoaldo added this to the Version 2.4 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants