The to-do list

[rootm0s]

The to-do list:

• Update all the "print_" messages so they make more sense
• Update all function descriptions so they are correct
• Update README
• A better way to do cleanup. Right now.. if function returns False in early stage, this prevents the cleanup in most of the functions. (Fixed in: f8dd0a6)
• Restructure winstructures, it's all messy right now
• Convert the code to python3 but keep python2 support so Pupy (https://github.com/n1nj4sec/pupy) can work
• Add automated testing (Travis CI, AppVeyor, etc.)
• Replace all sys.argv[] calls from main.py and use argparse instead (Fixed in: 7de4146)
• Deprecate py2exe support
• Remove py2exe from README
• Add better way to display the scan results
• Change Syntax winpwnage.py in README to main.py
• Deprecate DLL based methods/functions
• Remove Python2 support

[cclauss]

• Add automated testing (CircleCI, Travis CI, AppVeyor, etc.)?

[rootm0s]

• Add automated testing (CircleCI, Travis CI, AppVeyor, etc.)?

I do all the testing manually at the moment. I don't use any of those since there's no version-handling on this project. Is it simular to unittest?

[cclauss]

These are automated tools that test each pull request before it is reviewed. One of the tests that they could run could be unittests. They could also run other test frameworks (pytest) and linters (pylint, flake8, mypy, etc).

CPython runs several (click Show all checks):

• bpo-36366: Return None on stopping unstarted patch object python/cpython#12472 (comment)

[rootm0s]

Alright, thanks for the info. I'll add it to the todo!

[rootm0s]

Followed your steps and merged the PR @cclauss - let me know if I missed something, im new to Travis Ci.

[cclauss]

Tests are running now... #23

[rootm0s]

Merged #23 as well

[cclauss]

Nice work! So the rule going forward should be: If Travis is not green, the PR should not be merged.

[cclauss]

You can check the last box in the list above.

[rootm0s]

Nice work! So the rule going forward should be: If Travis is not green, the PR should not be merged.

Alright, good to know. Thanks!

You can check the last box in the list above.

Done!

[cclauss]

Is it time to check the second last box above?

[rootm0s]

Is it time to check the second last box above?

It is, going too! Thanks for all the help so far. Really appreciated!

[rootm0s]

Missclick, lol.

[rootm0s]

Restructure of winstructures is completed in PR 5cd9c8b

[rootm0s]

Readme got updated in: c7d895d

[rootm0s]

@cclauss Is it possible for Travis-ci to ignore colorama import if it's not being used? And just only colorama.

https://travis-ci.com/github/rootm0s/WinPwnage/jobs/307519521

Edit:
Is now fixed.

[rootm0s]

Added:

• Deprecate DLL based methods/functions

Reason:
Cannot support DLL based methods because I don't have the time to create proxy dll's and test existing functions and new functions. These methods are also quite messy in my opinion, payload can get stuck on disk while using UAC bypass method because the DLL was not unloaded correctly.

[psyraed]

#53

Used pyinstaller --onefile main.py to make main.exe

Whn i run it: main.exe -scan

C:\Users\Usuari\Desktop\WinPwnage-master\dist>main.exe -scan

[!] Comparing build number (18363) against 'Fixed In' build numbers

Id: Type: Compatible: Description:

---

No any scan provided

Thanks for help and congrats )

[rootm0s]

#53

Used pyinstaller --onefile main.py to make main.exe

Whn i run it: main.exe -scan

C:\Users\Usuari\Desktop\WinPwnage-master\dist>main.exe -scan

[!] Comparing build number (18363) against 'Fixed In' build numbers

Id: Type: Compatible: Description:

No any scan provided

Thanks for help and congrats )

You need to specify if you want to search for uac/persist/elevate methods.

main.exe -scan uac
main.exe -scan persist
main.exe -scan elevate

[cclauss]

It would be good if the software would display a clear warning if the user forgets to specify a search. Or it could execute a reasonable default.

[psyraed]

#53
Used pyinstaller --onefile main.py to make main.exe
Whn i run it: main.exe -scan
C:\Users\Usuari\Desktop\WinPwnage-master\dist>main.exe -scan
[!] Comparing build number (18363) against 'Fixed In' build numbers
Id: Type: Compatible: Description:
No any scan provided
Thanks for help and congrats )

You need to specify if you want to search for uac/persist/elevate methods.

main.exe -scan uac
main.exe -scan persist
main.exe -scan elevate

Hi )
Thanks for answering
Tried whith all, ( uac , persist , elevate) but no any scan.

seems maybe soft don't find the scripts to us or similar ?

thnx again

[rootm0s]

It would be good if the software would display a clear warning if the user forgets to specify a search. Or it could execute a reasonable default.

Agree, would be more user friendly. Or just add it to the README, some scan arguments so people understand how it works.

It does say it expect one more argument if only passing --scan/-s to main.py.

usage: main.py [-h] [-s SCAN [SCAN ...]] [-u USE [USE ...]] [-i ID [ID ...]] [-p PAYLOAD [PAYLOAD ...]] [-r]
main.py: error: argument -s/--scan: expected at least one argument

[rootm0s]

#53
Used pyinstaller --onefile main.py to make main.exe
Whn i run it: main.exe -scan
C:\Users\Usuari\Desktop\WinPwnage-master\dist>main.exe -scan
[!] Comparing build number (18363) against 'Fixed In' build numbers
Id: Type: Compatible: Description:
No any scan provided
Thanks for help and congrats )

You need to specify if you want to search for uac/persist/elevate methods.
main.exe -scan uac
main.exe -scan persist
main.exe -scan elevate

Hi )
Thanks for answering
Tried whith all, ( uac , persist , elevate) but no any scan.

seems maybe soft don't find the scripts to us or similar ?

thnx again

Create a separate issue here on Github and provide what python version you run, will try to help you.

It works locally here in 3 different VMs, also Travis CI is able to build and use the scan functions. Don't think it's a WinPwnage bug.

[rootm0s]

It would be good if the software would display a clear warning if the user forgets to specify a search. Or it could execute a reasonable default.

Added some examples to README for now:
a8ddf84