Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run pkgcheck on pkgcheck #180

Closed
3 of 4 tasks
mpadge opened this issue Jun 30, 2023 · 1 comment
Closed
3 of 4 tasks

run pkgcheck on pkgcheck #180

mpadge opened this issue Jun 30, 2023 · 1 comment

Comments

@mpadge
Copy link
Member

mpadge commented Jun 30, 2023

Was so busy checking everything outside this package that I completely negected to run pkgcheck on itself. Current results look like this:

Checks for pkgcheck (v0.1.1.026)

git hash: 6dd7b3ab

  • ✔️ Package name is available
  • ✔️ has a 'codemeta.json' file.
  • ✔️ has a 'contributing' file.
  • ✖️ The following functions have no documented return values: [print.pkgcheck, read_pkg_guide]
  • ✔️ uses 'roxygen2'.
  • ✔️ 'DESCRIPTION' has a URL field.
  • ✔️ 'DESCRIPTION' has a BugReports field.
  • ✔️ Package has at least one HTML vignette
  • ✖️ These functions do not have examples: [checks_to_markdown, get_default_github_branch, get_gh_token, get_latest_commit, logfile_names, pkgcheck_bg, pkgcheck, print.pkgcheck, read_pkg_guide, render_markdown].
  • ✔️ Package has continuous integration checks.
  • ✖️ Package coverage is 68.6% (should be at least 75%).
  • ✔️ R CMD check found no errors.
  • ✔️ R CMD check found no warnings.
  • 👀 Function names are duplicated in other packages

TODO

  • Document return values for [print.pkgcheck, read_pkg_guide]
  • Add examples for all functions which do not have them
  • Increase package coverage to > 75% Nope, coverage is actually 86%; that was a local glitch.
  • Fix duplicated function name: knitr::render_markdown()
mpadge added a commit that referenced this issue Jun 30, 2023
mpadge added a commit that referenced this issue Jun 30, 2023
@mpadge
Copy link
Member Author

mpadge commented Jun 30, 2023

First run is in (#181), and all is good, except coverage is ... 74.8%! Just have to increase that a tiny bit to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant