diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION index fb9d4485..066de0f8 100644 --- a/CRAN-SUBMISSION +++ b/CRAN-SUBMISSION @@ -1,3 +1,3 @@ Version: 0.1.2 -Date: 2024-01-15 02:07:42 UTC -SHA: 2f3e67b75fc2de3aff1823040068c854c37a18a9 +Date: 2024-01-15 23:45:43 UTC +SHA: 6eb9df73e540241691d9c72aade9f9b046b45437 diff --git a/DESCRIPTION b/DESCRIPTION index 26ab0c5f..1f2a62f4 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: aorsf Title: Accelerated Oblique Random Forests -Version: 0.1.2 +Version: 0.1.3 Authors@R: c( person("Byron", "Jaeger", , "bjaeger@wakehealth.edu", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-7399-2299")), diff --git a/NEWS.md b/NEWS.md index 1bbf759c..91c04087 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,8 @@ -# aorsf 0.1.2 (unreleased) +# aorsf 0.1.3 + +* minor changes to partial dependence vignette to resolve code sanitization errors. + +# aorsf 0.1.2 * Allowed option `"time"` for `pred_type` in `predict` and partial dependence to predict survival time (see https://github.com/ropensci/aorsf/issues/37). diff --git a/cran-comments.md b/cran-comments.md index 30ccded0..a4ae672e 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,5 +1,7 @@ ## Version 0.1.2 +Update 1/15. I have made some adjustments to the pd vignette based on problems shown on https://www.stats.ox.ac.uk/pub/bdr/memtests/clang-UBSAN/aorsf/build_vignettes.log. I really tried to replicate this error locally but I have not been successful yet. From what I can gather in the logs, I think the issue was caused by how an unsigned integer value is created when verbose output is requested from an aorsf function. + I have run R CMD check and have also checked for memory leaks using R CMD check --use-valgrind aorsf_0.1.2.tar.gz. ### Valgrind check results (abbreviated) diff --git a/man/orsf.Rd b/man/orsf.Rd index 1bd56e89..a95fae9d 100644 --- a/man/orsf.Rd +++ b/man/orsf.Rd @@ -388,7 +388,7 @@ penguin_fit ## N trees: 5 ## N predictors total: 7 ## N predictors per node: 3 -## Average leaves per tree: 4.4 +## Average leaves per tree: 5.4 ## Min observations in leaf: 5 ## OOB stat value: 0.99 ## OOB stat type: AUC-ROC @@ -415,9 +415,9 @@ bill_fit ## N trees: 5 ## N predictors total: 7 ## N predictors per node: 3 -## Average leaves per tree: 51.2 +## Average leaves per tree: 49.6 ## Min observations in leaf: 5 -## OOB stat value: 0.77 +## OOB stat value: 0.75 ## OOB stat type: RSQ ## Variable importance: anova ## @@ -447,10 +447,10 @@ pbc_fit ## N trees: 5 ## N predictors total: 17 ## N predictors per node: 5 -## Average leaves per tree: 20 +## Average leaves per tree: 20.8 ## Min observations in leaf: 5 ## Min events in leaf: 1 -## OOB stat value: 0.76 +## OOB stat value: 0.74 ## OOB stat type: Harrell's C-index ## Variable importance: anova ## @@ -497,7 +497,7 @@ take to fit the forest before you commit to it: orsf_time_to_train() }\if{html}{\out{}} -\if{html}{\out{
}}\preformatted{## Time difference of 2.4331 secs +\if{html}{\out{
}}\preformatted{## Time difference of 1.70388 secs }\if{html}{\out{
}} \enumerate{ \item If fitting multiple forests, use the blueprint along with @@ -568,12 +568,12 @@ brier_scores \if{html}{\out{
}}\preformatted{## # A tibble: 6 x 4 ## .metric .estimator .eval_time .estimate ## -## 1 brier_survival standard 500 0.0466 -## 2 brier_survival standard 1000 0.0754 -## 3 brier_survival standard 1500 0.0612 -## 4 brier_survival standard 2000 0.0885 -## 5 brier_survival standard 2500 0.133 -## 6 brier_survival standard 3000 0.141 +## 1 brier_survival standard 500 0.0264 +## 2 brier_survival standard 1000 0.0645 +## 3 brier_survival standard 1500 0.0759 +## 4 brier_survival standard 2000 0.117 +## 5 brier_survival standard 2500 0.176 +## 6 brier_survival standard 3000 0.223 }\if{html}{\out{
}} \if{html}{\out{
}}\preformatted{roc_scores <- test_pred \%>\% @@ -585,12 +585,12 @@ roc_scores \if{html}{\out{
}}\preformatted{## # A tibble: 6 x 4 ## .metric .estimator .eval_time .estimate ## -## 1 roc_auc_survival standard 500 0.947 -## 2 roc_auc_survival standard 1000 0.939 -## 3 roc_auc_survival standard 1500 0.982 -## 4 roc_auc_survival standard 2000 0.961 -## 5 roc_auc_survival standard 2500 0.929 -## 6 roc_auc_survival standard 3000 0.942 +## 1 roc_auc_survival standard 500 1 +## 2 roc_auc_survival standard 1000 0.921 +## 3 roc_auc_survival standard 1500 0.958 +## 4 roc_auc_survival standard 2000 0.936 +## 5 roc_auc_survival standard 2500 0.906 +## 6 roc_auc_survival standard 3000 0.887 }\if{html}{\out{
}} } } diff --git a/vignettes/pd_files/figure-html/unnamed-chunk-17-1.png b/vignettes/pd_files/figure-html/unnamed-chunk-17-1.png new file mode 100644 index 00000000..c1222728 Binary files /dev/null and b/vignettes/pd_files/figure-html/unnamed-chunk-17-1.png differ diff --git a/vignettes/pd_files/figure-html/unnamed-chunk-18-1.png b/vignettes/pd_files/figure-html/unnamed-chunk-18-1.png new file mode 100644 index 00000000..de5ff7e1 Binary files /dev/null and b/vignettes/pd_files/figure-html/unnamed-chunk-18-1.png differ diff --git a/vignettes/pd_files/figure-html/unnamed-chunk-21-1.png b/vignettes/pd_files/figure-html/unnamed-chunk-21-1.png new file mode 100644 index 00000000..ed4d5185 Binary files /dev/null and b/vignettes/pd_files/figure-html/unnamed-chunk-21-1.png differ