Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round digits in print.skim_df #620

Closed
wants to merge 1 commit into from
Closed

Round digits in print.skim_df #620

wants to merge 1 commit into from

Conversation

ben-schwen
Copy link

Closes #479

Added an additional argument round_early = TRUE to print.skim_df. If round_early is TRUE all doubles in the skim_df are rounded with round(skim_df, 4) before printing.

@elinw
Copy link
Collaborator

elinw commented Oct 18, 2020

We have spent a lot of time thinking about rounding and significant digits and also about many possible parameters that we could add. In particular in the case of digits we've thought about whether all of the numerics should get the same number of digits or not. This is especially something we are aware of since one purpose of skimr is to work in undergraduate courses. One question would be why you wouldn't use the API to define the specific way that you want rounding handled.

Also, are you saying you really don't care about the skim object here, just about controlling the printing?

@elinw
Copy link
Collaborator

elinw commented Nov 17, 2020

It has been about a month with no response ... i think maybe we need to document how to customize rounding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbers that should be zero are displayed in scientific notation
2 participants