Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest dependency on rgdal #51

Closed
maelle opened this issue Sep 2, 2024 · 6 comments
Closed

suggest dependency on rgdal #51

maelle opened this issue Sep 2, 2024 · 6 comments

Comments

@maelle
Copy link
Member

maelle commented Sep 2, 2024

is it still needed?
@Robinlovelace
Copy link
Member

Probably not, discussed recently with Rosa, thanks for raising this.

@maelle
Copy link
Member Author

maelle commented Sep 2, 2024

I noticed because I ran pak::pak() when testing things locally, and it failed because rgdal isn't available anymore from CRAN.

@temospena
Copy link
Collaborator

is it just a matter or removing rgdal from the "suggests" (once we already have sf at "imports")?

temospena added a commit that referenced this issue Oct 7, 2024
@temospena
remove rgdal from suggests #51
e3a3861 
and use up-to-date Roxygen
@maelle
Copy link
Member Author

maelle commented Oct 7, 2024

yes, if it's not needed. 😸 🙏

@Robinlovelace
Copy link
Member

👍

@temospena temospena mentioned this issue Oct 7, 2024
Merged
@maelle
Copy link
Member Author

maelle commented Oct 8, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Robinlovelace @maelle @temospena