Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top level layer of config YAML files #10

Open
pxalcantara opened this issue Nov 14, 2020 · 0 comments
Open

Remove top level layer of config YAML files #10

pxalcantara opened this issue Nov 14, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pxalcantara
Copy link
Collaborator

Remove the top-level names of the YAML files as suggested in #9,

For the config/motor.yaml I removed the top level motor: like it is done in base.yaml and front_wheel.yaml. This makes the code shorter inside common_macros.urdf.xacro. Maybe this could be used for the other yaml files as well because the description is already in the dictionary name, e.g. motor_props, base_prop, wheel_props. I think having base_prop['base']... and wheel_props['wheel']... is a bit redundant.

@pxalcantara pxalcantara added the enhancement New feature or request label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants