Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 resize and rectify always subscribe to the raw image #706

Closed
clydemcqueen opened this issue Oct 25, 2021 · 1 comment
Closed

ROS2 resize and rectify always subscribe to the raw image #706

clydemcqueen opened this issue Oct 25, 2021 · 1 comment
Labels

Comments

@clydemcqueen
Copy link

In ROS2 RectifyNode::subscribeToCamera calls image_transport::create_camera_subscription, which doesn't get the value of the image_transport parameter, so it always subscribes to the raw image on the base topic.

In ROS1 RectifyNodelet::connectCb calls image_transport::subscribeCamera and passes in a TransportHint. The TransportHint object will get the value of the image_transport parameter, allowing users to choose a different transport at runtime.

image_transport::TransportHints hints("raw", ros::TransportHints(), getPrivateNodeHandle());

Same goes for ResizeNode.

I'm not sure if the fix should land in image_transport or image_proc.

Thanks.

@mikeferguson
Copy link
Member

Added to meta ticket for image_transport updates: #854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants