Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for additional parameters of depth_image_proc::RegisterNode #956

Closed
Alessio-Parmeggiani opened this issue Feb 29, 2024 · 3 comments
Closed

Add documentation for additional parameters of depth_image_proc::RegisterNode #956

Alessio-Parmeggiani opened this issue Feb 29, 2024 · 3 comments

Comments

@Alessio-Parmeggiani
Copy link
Contributor

Hi, I noticed that the parameter fill_upsampling_holes and use_rgb_timestamp of the register node from depth_image_proc are not specified in the Documentation page.

They could be added with the documentation with the text:

  • use_rgb_timestamp (bool, default: false) : use timestamp of rgb image instead of depth image for the registered image.
  • fill_upsampling_holes (bool, default: false) : when RGB is higher res, interpolate by rasterizing depth triangles onto the registered image.
@ahcorde
Copy link
Contributor

ahcorde commented Feb 29, 2024

@Alessio-Parmeggiani do you mind to open a PR ?

@Alessio-Parmeggiani Alessio-Parmeggiani mentioned this issue Mar 1, 2024
Merged
@Alessio-Parmeggiani
Copy link
Contributor Author

@ahcorde Certainly, I opened a Pull Request #957.
It's the first time I make a pull request, I hope I did everything correctly

ahcorde pushed a commit that referenced this issue Mar 1, 2024
@Alessio-Parmeggiani
Update depth_image_proc::RegisterNode documentation (#957)
b883943 
Adding missing parameters from register node of depth_image_proc
package.
Related to Issue #956
@ahcorde
Copy link
Contributor

ahcorde commented Mar 1, 2024

All good, Thank you for your contribution!

@ahcorde ahcorde closed this as completed Mar 1, 2024
Kotochleb pushed a commit to Kotochleb/image_pipeline that referenced this issue May 27, 2024
@Alessio-Parmeggiani
Update depth_image_proc::RegisterNode documentation (ros-perception#957)
bd9b73f 
Adding missing parameters from register node of depth_image_proc
package.
Related to Issue ros-perception#956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahcorde @Alessio-Parmeggiani