Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure since galactic due to missing default_value for period parameter #13

Open
nlimpert opened this issue Aug 17, 2023 · 2 comments · May be fixed by #14
Open

Build failure since galactic due to missing default_value for period parameter #13

nlimpert opened this issue Aug 17, 2023 · 2 comments · May be fixed by #14

Comments

@nlimpert
Copy link

rclcpp API changes between foxy and galactic enforce the default_value for declare_parameter:

Hence starting with galactic the sw_watchdog package's simple_heartbeat node won't build as it does not set any default value.

I was going to fix this myself but saw that @jeskesen created a patch for this - @jeskesen would you mind creating a PR accordingly so we can discuss what's required to merge this?

@Hommus
Copy link

Hommus commented Oct 23, 2023

Keen to see this merged 👍

@vinnnyr
Copy link
Contributor

vinnnyr commented Jan 29, 2024

Coincidentally was blowing some dust off an old project and ran into the same thing. Implemented the same change as above and opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants