Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing CI has scary annotations because of tests #333

Open
rotu opened this issue Sep 4, 2020 · 0 comments
Open

Passing CI has scary annotations because of tests #333

rotu opened this issue Sep 4, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@rotu
Copy link
Contributor

rotu commented Sep 4, 2020

Description

CI for this repo has "Check failure" annotations even when tests pass.

Expected Behavior

No annotations should be seen if everything is working as it should

Actual Behavior

"Check failure" annotations are seen in every run of this repo's CI.
https://github.com/ros-tooling/action-ros-ci/actions/runs/238503302
Screenshot from 2020-09-03 19-52-43

To Reproduce

https://github.com/ros-tooling/action-ros-ci/actions/runs/238503302
@rotu rotu added the bug Something isn't working label Sep 4, 2020
@rotu rotu changed the title Tests add scary annotations when things fail as expected Tests add scary annotations because of tests Sep 11, 2020
@rotu rotu changed the title Tests add scary annotations because of tests Passing CI has scary annotations because of tests Sep 11, 2020
@emersonknapp emersonknapp added bug Something isn't working and removed bug Something isn't working labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rotu @emersonknapp