Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lifecycle nodes #296

Open
jhdcs opened this issue Nov 29, 2022 · 2 comments
Open

Implement lifecycle nodes #296

jhdcs opened this issue Nov 29, 2022 · 2 comments

Comments

@jhdcs
Copy link
Collaborator

jhdcs commented Nov 29, 2022

Some ROS 2 applications in other languages require the use of lifecycle nodes. We should work on creating/fleshing out the ros2_rust version of these, so that we can support more types of solutions.

I am unsure of how difficult this will be to port over, or if it's a good first issue for the community...

@fmrico
Copy link

fmrico commented Dec 30, 2023

Hi @jhdcs

Are you currently working on this feature? In that case, may I help you?

@jhdcs
Copy link
Collaborator Author

jhdcs commented Jan 2, 2024

Yes I am! Though progress is admittedly slow.

I would welcome any and all help that you would like to provide! I'm currently trying to create a unit test to make sure what I've written so far is working correctly, and ironing out any bugs discovered. So far, I'm not happy with the ergonomics of the builder, though I'm drawing a blank on improving it. I've also noticed that if you try to do an invalid transition between states, a segfault occurs - that will need to be fixed as well.

All work is currently being done on my personal fork: https://github.com/jhdcs/ros2_rust/tree/lifecycle_nodes. If you see any ways to improve/tweak what's there, or any glaring faults, please feel free to either let me know or submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants