Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Deployment Visualizing External Node Communications #243

Open
jeholliday opened this issue Mar 31, 2018 · 5 comments
Open

Support for Deployment Visualizing External Node Communications #243

jeholliday opened this issue Mar 31, 2018 · 5 comments
Assignees
Milestone

Comments

@jeholliday
Copy link

Right now, the deployment commsviz only shows the message connections between self defined messages. It would be good if it could also show connections between external messages and external nodes.

@finger563 finger563 added this to the Version 1.3.0 milestone Apr 1, 2018
@finger563
Copy link
Member

Unfortunately we have no model for what topics external nodes pub/sub/provide/require and on what names - we've talked about adding this but there is no real standard way of discovering them - so we'd have to have the user manually make them within the model (which isn't great because it is error prone and increases the development burden for something that's purely viz). That being said, we're still considering it.

@finger563
Copy link
Member

@jeholliday we're definitely open to suggestions for how you might want to represent / model such topics / advertisements

@jeholliday
Copy link
Author

I understand how visualizing messages coming from external nodes would be difficult. Having the external nodes in the visualization isn't necessary but external messages would be useful. It appears that even if a ROSMOD defined node is publishing an external message, and then another ROSMOD defined node subscribes to it, that message doesn't show up in the visualization.

@AWatk
Copy link
Member

AWatk commented Apr 4, 2018

That should be as simple as adding the External Message meta type to the valid objects and ptr list in CommVizControl.js, right @finger563 ?

@finger563
Copy link
Member

Yea @dwatkins and @jeholliday that's an easy thing to add - open a separate issue for it and I'll take care of it tomorrow

@finger563 finger563 changed the title Support for Deployment Visualizing External Messages Support for Deployment Visualizing External Node Communications Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants