From ffde818c1baea078565d2a6a56d111eb62feb08e Mon Sep 17 00:00:00 2001 From: Kyle Conroy Date: Thu, 12 Oct 2023 12:39:15 -0400 Subject: [PATCH] Aperture photometry: refactor, batch mode, enable user API (#2465) --- CHANGES.rst | 2 + docs/imviz/plugins.rst | 4 +- jdaviz/components/plugin_dataset_select.vue | 65 +- jdaviz/components/plugin_layer_select.vue | 2 +- jdaviz/components/plugin_subset_select.vue | 14 +- .../metadata_viewer/metadata_viewer.py | 4 + .../plugins/subset_plugin/subset_plugin.py | 41 +- jdaviz/configs/imviz/helper.py | 2 +- .../aper_phot_simple/aper_phot_simple.py | 711 +++++++++++------- .../aper_phot_simple/aper_phot_simple.vue | 86 ++- jdaviz/configs/imviz/tests/test_parser.py | 6 +- .../imviz/tests/test_simple_aper_phot.py | 112 +-- jdaviz/core/region_translators.py | 10 +- jdaviz/core/template_mixin.py | 228 ++++-- .../concepts/imviz_advanced_aper_phot.ipynb | 12 +- .../concepts/imviz_simple_aper_phot.ipynb | 4 +- 16 files changed, 850 insertions(+), 453 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index c388c4f9c1..6196f6a6dd 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -12,6 +12,8 @@ Cubeviz Imviz ^^^^^ +- Aperture photometry (previously "Imviz Simple Aperture Photometry") now supports batch mode. [#2465] + Mosviz ^^^^^^ diff --git a/docs/imviz/plugins.rst b/docs/imviz/plugins.rst index c2da960ffa..c4fd9ed45b 100644 --- a/docs/imviz/plugins.rst +++ b/docs/imviz/plugins.rst @@ -161,8 +161,8 @@ This plugin only considers pixel locations, not sky coordinates. .. _aper-phot-simple: -Simple Aperture Photometry -========================== +Aperture Photometry +=================== .. warning:: diff --git a/jdaviz/components/plugin_dataset_select.vue b/jdaviz/components/plugin_dataset_select.vue index 2b2e2f5ce7..e13d4fe3aa 100644 --- a/jdaviz/components/plugin_dataset_select.vue +++ b/jdaviz/components/plugin_dataset_select.vue @@ -10,39 +10,68 @@ :label="label ? label : 'Data'" :hint="hint ? hint : 'Select data.'" :rules="rules ? rules : []" + :multiple="multiselect" + :chips="multiselect" item-text="label" item-value="label" persistent-hint > - - + + + -