Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not support set badge count in text format #856

Open
itman85 opened this issue Oct 6, 2017 · 3 comments
Open

Not support set badge count in text format #856

itman85 opened this issue Oct 6, 2017 · 3 comments

Comments

@itman85
Copy link

itman85 commented Oct 6, 2017

I currently cannot set badge count in text format. In case number is large such as 150,200... i want to display badge number as "99+". But there is method set badge with integer only.

@itman85 itman85 changed the title Support set badge count in text format Not support set badge count in text format Oct 6, 2017
@leonardo2204
Copy link
Contributor

leonardo2204 commented Oct 8, 2017

The problem with this approach is that some logic is performed behind the badge count (like hiding or showing if greater or less than 0), so I'm not sure how the app should behave when having String values.
IMO, I'd agree implementing something like TextView's ellipse (using a threshold), like, if count > x show '+' sign.
What do you think @itman85 and @roughike ?
I'd gladly drop a PR !

@itman85
Copy link
Author

itman85 commented Oct 9, 2017

That's awesome if support a threshold to show plus sign and setting text size

@leonardo2204
Copy link
Contributor

@itman85 PR #859 created.
Now we wait :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants