Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wildcard(*) in "Access-Control-Allow-Headers" and "Access-Control-Allow-Methods" are not supported in Safari and Android firefox browsers. #1

Open
rousan opened this issue Jul 30, 2020 · 0 comments

Comments

@rousan
Copy link
Member

rousan commented Jul 30, 2020

Add an option to give allowed headers, allowed methods and allowed origins from user.

An alternative version of the current implementation is:

async fn cors_middleware(mut res: HttpResponse, req_info: RequestInfo) -> crate::Result<HttpResponse> {
    let headers = res.headers_mut();

    headers.insert(header::ACCESS_CONTROL_ALLOW_ORIGIN, HeaderValue::from_static("*"));
    headers.insert(
        header::ACCESS_CONTROL_ALLOW_METHODS,
        // Do not use "*" as this wildcard is not supported in safari etc browsers.
        HeaderValue::from_static("GET,HEAD,POST,PUT,DELETE,CONNECT,OPTIONS,TRACE,PATCH"),
    );

    if let Some(requested_headers) = req_info.headers().get(header::ACCESS_CONTROL_REQUEST_HEADERS) {
        headers.insert(header::ACCESS_CONTROL_ALLOW_HEADERS, requested_headers.clone());
    } else {
        headers.insert(header::ACCESS_CONTROL_ALLOW_HEADERS, HeaderValue::from_static("*"));
    }

    Ok(res)
}

References
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Methods
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers

@rousan rousan changed the title The wildcard in "Access-Control-Expose-Headers" and "Access-Control-Allow-Methods" are not supported in Safari and Android firefox etc. The wildcard(*) in "Access-Control-Expose-Headers" and "Access-Control-Allow-Methods" are not supported in Safari and Android firefox etc. Jul 30, 2020
@rousan rousan changed the title The wildcard(*) in "Access-Control-Expose-Headers" and "Access-Control-Allow-Methods" are not supported in Safari and Android firefox etc. The wildcard(*) in "Access-Control-Allow-Headers" and "Access-Control-Allow-Methods" are not supported in Safari and Android firefox browsers. Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant