Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: initial check for fdt and its containing buffer #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fozog
Copy link

@fozog fozog commented Jan 13, 2023

It is not inherently an error to have a containing buffer larger than the actual FDT. FDTs can be grown and hence a larger buffer may just accomodate expected growths.

However, a buffer that is actually smaller than the value in the FDT header does not represent a valid situation and it is better to bail off early.

It is not inherently an error to have a containing buffer larger
than the actual FDT. FDTs can be grown and hence a larger buffer
may just accomodate expected growths.

However, a buffer that is actually smaller than the value in the
FDT header does not represent a valid situation and it is better
to bail off early.
@coveralls
Copy link

coveralls commented Jan 13, 2023

Pull Request Test Coverage Report for Build 3912025538

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.657%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/base/tree.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 3905624911: 0.0%
Covered Lines: 556
Relevant Lines: 932

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants