diff --git a/experimental/yarpl/include/yarpl/Observable.h b/experimental/yarpl/include/yarpl/Observable.h index b0cc49748..2eb77f92a 100644 --- a/experimental/yarpl/include/yarpl/Observable.h +++ b/experimental/yarpl/include/yarpl/Observable.h @@ -65,7 +65,7 @@ class Observable : public virtual Refcounted { template class FromPublisherOperator : public Observable { public: - FromPublisherOperator(OnSubscribe&& function) + explicit FromPublisherOperator(OnSubscribe&& function) : function_(std::move(function)) {} void subscribe(Reference> subscriber) override { diff --git a/experimental/yarpl/include/yarpl/Refcounted.h b/experimental/yarpl/include/yarpl/Refcounted.h index 9a87f00a5..4fb7f1e1a 100644 --- a/experimental/yarpl/include/yarpl/Refcounted.h +++ b/experimental/yarpl/include/yarpl/Refcounted.h @@ -81,7 +81,7 @@ class Reference { inc(); } - Reference(Reference&& other) : pointer_(other.pointer_) { + Reference(Reference&& other) noexcept : pointer_(other.pointer_) { other.pointer_ = nullptr; } diff --git a/experimental/yarpl/include/yarpl/flowable/FlowableOperator.h b/experimental/yarpl/include/yarpl/flowable/FlowableOperator.h index 292895db8..ee3cffa29 100644 --- a/experimental/yarpl/include/yarpl/flowable/FlowableOperator.h +++ b/experimental/yarpl/include/yarpl/flowable/FlowableOperator.h @@ -247,7 +247,7 @@ class SubscribeOnOperator : public FlowableOperator { template class FromPublisherOperator : public Flowable { public: - FromPublisherOperator(OnSubscribe&& function) + explicit FromPublisherOperator(OnSubscribe&& function) : function_(std::move(function)) {} void subscribe(Reference> subscriber) override { diff --git a/experimental/yarpl/include/yarpl/observable/ObservableOperator.h b/experimental/yarpl/include/yarpl/observable/ObservableOperator.h index 5d0b9c474..7e6b6bf9c 100644 --- a/experimental/yarpl/include/yarpl/observable/ObservableOperator.h +++ b/experimental/yarpl/include/yarpl/observable/ObservableOperator.h @@ -224,7 +224,7 @@ class SubscribeOnOperator : public ObservableOperator { template class FromPublisherOperator : public Observable { public: - FromPublisherOperator(OnSubscribe&& function) + explicit FromPublisherOperator(OnSubscribe&& function) : function_(std::move(function)) {} void subscribe(Reference> subscriber) override { diff --git a/experimental/yarpl/include/yarpl/observable/Observers.h b/experimental/yarpl/include/yarpl/observable/Observers.h index 6ce41d937..3e6a27e35 100644 --- a/experimental/yarpl/include/yarpl/observable/Observers.h +++ b/experimental/yarpl/include/yarpl/observable/Observers.h @@ -73,7 +73,7 @@ class Observers { template class Base : public Observer { public: - Base(Next&& next) + explicit Base(Next&& next) : next_(std::forward(next)) {} void onNext(T value) override { diff --git a/experimental/yarpl/test/Observable_test.cpp b/experimental/yarpl/test/Observable_test.cpp index d324fb7f8..e249787d6 100644 --- a/experimental/yarpl/test/Observable_test.cpp +++ b/experimental/yarpl/test/Observable_test.cpp @@ -383,7 +383,8 @@ TEST(Observable, DISABLED_SimpleTake) { } TEST(Observable, Error) { - auto observable = Observables::error(std::runtime_error("something broke!")); + auto observable = + Observables::error(std::runtime_error("something broke!")); auto collector = make_ref>(); observable->subscribe(collector);