From a1f475bed9ebacbb568694cdff42abec9453a944 Mon Sep 17 00:00:00 2001 From: Luca Niccolini Date: Thu, 1 Oct 2020 09:43:10 -0700 Subject: [PATCH] Disable tests on windows Summary: hitting https://github.com/google/googletest/issues/1373 Reviewed By: mjoras Differential Revision: D23785392 fbshipit-source-id: 114849ed966fb196bb8392bd71ee3c2972834279 --- build/fbcode_builder/manifests/fizz | 6 ++++-- build/fbcode_builder/manifests/mvfst | 5 ++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/build/fbcode_builder/manifests/fizz b/build/fbcode_builder/manifests/fizz index ec9cc2d0b..da54b1119 100644 --- a/build/fbcode_builder/manifests/fizz +++ b/build/fbcode_builder/manifests/fizz @@ -17,15 +17,17 @@ BUILD_EXAMPLES = OFF [cmake.defines.test=on] BUILD_TESTS = ON -[cmake.defines.test=off] +[cmake.defines.all(os=windows, test=on)] BUILD_TESTS = OFF +[cmake.defines.test=off] +BUILD_TESTS = OFF [dependencies] folly libsodium -[dependencies.test=on] +[dependencies.all(test=on, not(os=windows))] googletest_1_8 [shipit.pathmap] diff --git a/build/fbcode_builder/manifests/mvfst b/build/fbcode_builder/manifests/mvfst index dc91f61f6..4f72a9192 100644 --- a/build/fbcode_builder/manifests/mvfst +++ b/build/fbcode_builder/manifests/mvfst @@ -14,6 +14,9 @@ subdir = . [cmake.defines.test=on] BUILD_TESTS = ON +[cmake.defines.all(os=windows, test=on)] +BUILD_TESTS = OFF + [cmake.defines.test=off] BUILD_TESTS = OFF @@ -21,7 +24,7 @@ BUILD_TESTS = OFF folly fizz -[dependencies.test=on] +[dependencies.all(test=on, not(os=windows))] googletest_1_8 [shipit.pathmap]