Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(partially) removing core peripherals from RTIC context #746

Closed
romancardenas opened this issue Apr 27, 2023 · 4 comments · Fixed by #815
Closed

(partially) removing core peripherals from RTIC context #746

romancardenas opened this issue Apr 27, 2023 · 4 comments · Fixed by #815

Comments

@romancardenas
Copy link
Contributor

As discussed in the previous meeting, now that RTIC v2 targets multiple architectures, some items seem too biased toward Cortex-M microcontrollers.

One of these elements is rtic::export::Peripherals. For instance, the RISC-V architecture does not have a common set of peripherals, and the current successful ports (#733 or greenlsi/rtic) end up re-exporting the device peripherals twice.

The main options we discussed to tackle this issue are:

  1. Leave rtic::export::Peripherals as () when not needed.
  2. Feature-gate the core peripherals of the context so it is only active when it makes sense.
  3. Completely remove core peripherals from RTIC.

It would be nice to have a discussion about this topic. Personally, I'm inclined to the third option, as we would keep a common interface for all the targets. However, it may break already working examples/projects.

@korken89
Copy link
Collaborator

I think we can remove it. It's only a rename is cortex-m peripherals, and we can use it's full name instead.

@AfoHT
Copy link
Contributor

AfoHT commented Oct 4, 2023

Now with the awesome work in #733 merged, how should we go about this? Breaking change if we remove it altogether, but it would be cleaner 👍

@romancardenas
Copy link
Contributor Author

I'm currently working on a PR for adding support to RISC-V targets over the SLIC. I hope to be done this week. Maybe I can add this change to the PR and discuss there.

@romancardenas
Copy link
Contributor Author

PR opened: #815

@AfoHT AfoHT linked a pull request Mar 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants