-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(partially) removing core peripherals from RTIC context #746
Comments
I think we can remove it. It's only a rename is cortex-m peripherals, and we can use it's full name instead. |
Now with the awesome work in #733 merged, how should we go about this? Breaking change if we remove it altogether, but it would be cleaner 👍 |
I'm currently working on a PR for adding support to RISC-V targets over the SLIC. I hope to be done this week. Maybe I can add this change to the PR and discuss there. |
PR opened: #815 |
As discussed in the previous meeting, now that RTIC v2 targets multiple architectures, some items seem too biased toward Cortex-M microcontrollers.
One of these elements is
rtic::export::Peripherals
. For instance, the RISC-V architecture does not have a common set of peripherals, and the current successful ports (#733 or greenlsi/rtic) end up re-exporting the device peripherals twice.The main options we discussed to tackle this issue are:
rtic::export::Peripherals
as()
when not needed.It would be nice to have a discussion about this topic. Personally, I'm inclined to the third option, as we would keep a common interface for all the targets. However, it may break already working examples/projects.
The text was updated successfully, but these errors were encountered: