Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing nop from rtic::export #747

Closed
romancardenas opened this issue May 3, 2023 · 1 comment · Fixed by #810
Closed

Removing nop from rtic::export #747

romancardenas opened this issue May 3, 2023 · 1 comment · Fixed by #810

Comments

@romancardenas
Copy link
Contributor

As discussed in #733, re-exporting nop in rtic::export may be unnecessary, and something like continue would do the trick in most cases. Personally, I'd keep the mandatory elements of rtic::export to the minimum. If anyone needs by chance the cortex_m::nop instruction, I'd say that they use it directly from the cortex-m crate instead of RTIC's re-export.

@korken89
Copy link
Collaborator

This sounds good to me. It's a remnant from when loop optimization was broken I'm the compiler.

@AfoHT AfoHT linked a pull request Oct 4, 2023 that will close this issue
@AfoHT AfoHT closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants