Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make index pattern always show under library #115

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Hailong-am
Copy link
Collaborator

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #115 (5a93927) into workspace (acaf609) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 5a93927 differs from pull request most recent head d2313f8. Consider uploading reports for the commit d2313f8 to get more accurate results

@@            Coverage Diff             @@
##           workspace     #115   +/-   ##
==========================================
  Coverage      65.77%   65.78%           
==========================================
  Files           3336     3336           
  Lines          64492    64486    -6     
  Branches       10264    10264           
==========================================
  Hits           42420    42420           
+ Misses         19496    19490    -6     
  Partials        2576     2576           
Flag Coverage Δ
Linux_1 34.75% <0.00%> (ø)
Linux_3 42.64% <0.00%> (-0.01%) ⬇️
Windows_1 34.77% <0.00%> (ø)
Windows_2 54.74% <0.00%> (ø)
Windows_3 42.64% <0.00%> (ø)
Windows_4 34.74% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...on/index_patterns/index_patterns/index_patterns.ts 56.33% <0.00%> (ø)
...terns/index_patterns/redirect_no_index_pattern.tsx 6.66% <0.00%> (ø)
...lugins/data/server/saved_objects/index_patterns.ts 25.00% <0.00%> (ø)
.../plugins/index_pattern_management/public/plugin.ts 7.14% <0.00%> (+1.26%) ⬆️
...lic/components/getting_started/getting_started.tsx 85.71% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hailong-am Hailong-am merged commit 081046e into ruanyl:workspace Aug 30, 2023
23 of 42 checks passed
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 31, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants