Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use passed ACLSearchParams.permissionModes #181

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Sep 19, 2023

Description

  1. use passed ACLSearchParams.permissionModes
  2. move getPermittedWorkspaceIds to find method
  3. remove permissionModes parameter, use ACLSearchParams.permissionModes instead

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #181 (f11d660) into workspace (ccd0520) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #181      +/-   ##
=============================================
- Coverage      60.58%   60.17%   -0.41%     
=============================================
  Files           2992     2160     -832     
  Lines          58610    42113   -16497     
  Branches        9531     7729    -1802     
=============================================
- Hits           35508    25343   -10165     
+ Misses         21015    15078    -5937     
+ Partials        2087     1692     -395     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.05% <ø> (ø)
Linux_3 42.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 905 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wanglam wanglam marked this pull request as ready for review September 19, 2023 06:59
@wanglam wanglam requested a review from ruanyl September 19, 2023 09:49
…use passed value

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam force-pushed the refactor-workspace-permission-control-find branch from 9201b6d to 06db259 Compare September 20, 2023 06:36
Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam force-pushed the refactor-workspace-permission-control-find branch from 06db259 to f11d660 Compare September 20, 2023 06:38
@wanglam wanglam merged commit 33e90ec into ruanyl:workspace Sep 20, 2023
20 of 21 checks passed
@opensearch-workspace-development

The backport to workspace-2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-181-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 33e90ec92c93653ac17c72e2348c1f32ba53661c
# Push it to GitHub
git push --set-upstream origin backport/backport-181-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9

Then, create a pull request where the base branch is workspace-2.9 and the compare/head branch is backport/backport-181-to-workspace-2.9.

raintygao pushed a commit that referenced this pull request Sep 21, 2023
* feat: workspace saved client wrapper ACLSearchParams.permissionModes use passed value

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: move getPermittedWorkspaceIds inner find method

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove permissionModes in savedobject client find method

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
(cherry picked from commit 33e90ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants