-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use passed ACLSearchParams.permissionModes #181
feat: use passed ACLSearchParams.permissionModes #181
Conversation
Codecov Report
@@ Coverage Diff @@
## workspace #181 +/- ##
=============================================
- Coverage 60.58% 60.17% -0.41%
=============================================
Files 2992 2160 -832
Lines 58610 42113 -16497
Branches 9531 7729 -1802
=============================================
- Hits 35508 25343 -10165
+ Misses 21015 15078 -5937
+ Partials 2087 1692 -395
Flags with carried forward coverage won't be shown. Click here to find out more. see 905 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…use passed value Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
9201b6d
to
06db259
Compare
Signed-off-by: Lin Wang <wonglam@amazon.com>
06db259
to
f11d660
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-181-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 33e90ec92c93653ac17c72e2348c1f32ba53661c
# Push it to GitHub
git push --set-upstream origin backport/backport-181-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 Then, create a pull request where the |
* feat: workspace saved client wrapper ACLSearchParams.permissionModes use passed value Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: move getPermittedWorkspaceIds inner find method Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: remove permissionModes in savedobject client find method Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 33e90ec)
Description
ACLSearchParams.permissionModes
insteadIssues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr