Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use self hosted runner and disable windows workflow #182

Merged
merged 5 commits into from
Sep 20, 2023
Merged

use self hosted runner and disable windows workflow #182

merged 5 commits into from
Sep 20, 2023

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Sep 19, 2023 •
edited
Loading

Description

Use self hosted runner and disable windows workflow + use forked functional-test repo for development

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ruanyl and others added 2 commits September 19, 2023 17:11
@ruanyl @SuZhou-Joe
disable github workflows running on windows for development (#161)
81de2e7 
the jobs for windows are queued forever, disable it for development

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

temp: skip bwc-tests

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
@ruanyl
fix cypress test missing ref
cd17702 
use forked function-test repo for development

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #182 (03d3e87) into workspace-pr-integr (f1eb762) will decrease coverage by 0.05%.
Report is 1 commits behind head on workspace-pr-integr.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #182      +/-   ##
=======================================================
- Coverage                66.50%   66.46%   -0.05%     
=======================================================
  Files                     3406     3408       +2     
  Lines                    65111    65209      +98     
  Branches                 10426    10436      +10     
=======================================================
+ Hits                     43302    43340      +38     
- Misses                   19221    19274      +53     
- Partials                  2588     2595       +7
Flag Coverage Δ
Linux_ 66.02% <ø> (?)
Linux_1 ?
Linux_2 ?
Linux_3 ?
Linux_4 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?
_1 34.78% <ø> (?)
_2 55.39% <ø> (?)
_3 44.53% <ø> (?)
_4 34.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SuZhou-Joe
SuZhou-Joe reviewed Sep 20, 2023
View reviewed changes
.github/workflows/build_and_test_workflow.yml Outdated
@@ -307,6 +298,7 @@ jobs:
retention-days: 1

bwc-tests:
if: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can enable bwc-tests?

@ruanyl
get bwc test back
2591c24 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
raintygao
raintygao reviewed Sep 20, 2023
View reviewed changes
.github/workflows/cypress_workflow.yml
@@ -54,7 +54,7 @@ jobs:
uses: actions/checkout@v2
with:
path: ${{ env.FTR_PATH }}
repository: opensearch-project/opensearch-dashboards-functional-test
repository: ruanyl/opensearch-dashboards-functional-test
ref: '${{ github.base_ref }}'
Copy link
Collaborator

@raintygao raintygao Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanyl @SuZhou-Joe Do we need to set ref to workspace branch of FT repo to do workspace-specific test integration?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both should work, what about using workspace branch as the ref for our development? @ruanyl

Copy link
Collaborator

@raintygao raintygao Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been some commits to fix workspace failed FT on the workspace branch. https://github.com/opensearch-project/opensearch-dashboards-functional-test/commits/workspace. Or we can also migrate them later.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work, I will update

@ruanyl
update cypress workflows to use workspace branch of ftr repo
499f5ad 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl merged commit f630277 into workspace-pr-integr Sep 20, 2023
63 checks passed
wanglam pushed a commit that referenced this pull request Feb 26, 2024
@ruanyl @SuZhou-Joe @wanglam
use self hosted runner and disable windows workflow (#182)
50c20c1 
disable github workflows running on windows for development (#161)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit that referenced this pull request Mar 18, 2024
@ruanyl @SuZhou-Joe
use self hosted runner and disable windows workflow (#182)
5876656 
disable github workflows running on windows for development (#161)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe left review comments

@Hailong-am Hailong-am Hailong-am approved these changes

@raintygao raintygao raintygao approved these changes

@wanglam wanglam Awaiting requested review from wanglam

Assignees
No one assigned
Labels
seasoned-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ruanyl @codecov-commenter @SuZhou-Joe @raintygao @Hailong-am