Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit test for share/delete api #184

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Sep 20, 2023

Description

  1. make addToWorkspaceOptions extends SavedObjectsBaseOptions
  2. Add unit test

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #184 (3288e55) into workspace (37171cf) will increase coverage by 0.09%.
The diff coverage is 61.11%.

@@              Coverage Diff              @@
##           workspace     #184      +/-   ##
=============================================
+ Coverage      66.12%   66.21%   +0.09%     
=============================================
  Files           3420     3420              
  Lines          65753    65755       +2     
  Branches       10590    10589       -1     
=============================================
+ Hits           43479    43541      +62     
+ Misses         19633    19571      -62     
- Partials        2641     2643       +2     
Flag Coverage Δ
Linux_1 30.42% <0.00%> (-0.01%) ⬇️
Linux_2 55.38% <61.11%> (+0.26%) ⬆️
Linux_3 42.76% <0.00%> (-0.01%) ⬇️
Linux_4 34.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/server/index.ts 100.00% <ø> (ø)
src/core/server/saved_objects/routes/utils.ts 100.00% <100.00%> (ø)
...saved_objects/service/saved_objects_client.mock.ts 100.00% <ø> (ø)
...rver/saved_objects/service/saved_objects_client.ts 55.17% <ø> (ø)
...ore/server/saved_objects/service/lib/repository.ts 89.43% <76.92%> (+11.09%) ⬆️
src/core/server/saved_objects/routes/share.ts 12.00% <0.00%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hailong-am Hailong-am requested a review from wanglam September 20, 2023 09:15
@Hailong-am Hailong-am force-pushed the feature/workspace branch 3 times, most recently from 006d195 to 68c9750 Compare September 21, 2023 00:21
@Hailong-am Hailong-am marked this pull request as draft September 21, 2023 03:19
@Hailong-am Hailong-am changed the title few changes for share/delete api Add more unit test for share/delete api Sep 21, 2023
@Hailong-am Hailong-am marked this pull request as ready for review September 25, 2023 03:37
@Hailong-am Hailong-am force-pushed the feature/workspace branch 2 times, most recently from 5e09396 to 388712a Compare September 25, 2023 03:54
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am merged commit 8132e14 into ruanyl:workspace Oct 9, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants