forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more unit test for share/delete api #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #184 +/- ##
=============================================
+ Coverage 66.12% 66.21% +0.09%
=============================================
Files 3420 3420
Lines 65753 65755 +2
Branches 10590 10589 -1
=============================================
+ Hits 43479 43541 +62
+ Misses 19633 19571 -62
- Partials 2641 2643 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hailong-am
force-pushed
the
feature/workspace
branch
3 times, most recently
from
September 21, 2023 00:21
006d195
to
68c9750
Compare
Hailong-am
changed the title
few changes for share/delete api
Add more unit test for share/delete api
Sep 21, 2023
Hailong-am
force-pushed
the
feature/workspace
branch
2 times, most recently
from
September 25, 2023 03:54
5e09396
to
388712a
Compare
Hailong-am
force-pushed
the
feature/workspace
branch
from
September 25, 2023 06:11
388712a
to
891a91a
Compare
SuZhou-Joe
reviewed
Oct 8, 2023
SuZhou-Joe
approved these changes
Oct 8, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
feature/workspace
branch
from
October 9, 2023 02:36
e2ce999
to
3288e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr