Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App category changes - (Index pattern) #187

Closed

Conversation

Hailong-am
Copy link
Collaborator

Description

  1. Move index pattern from Management/Dashboards management to Library

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #187 (f8f02aa) into workspace-pr-integr (5bc2ddf) will decrease coverage by 0.02%.
The diff coverage is 5.88%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #187      +/-   ##
=======================================================
- Coverage                66.46%   66.45%   -0.02%     
=======================================================
  Files                     3408     3408              
  Lines                    65148    65156       +8     
  Branches                 10430    10432       +2     
=======================================================
- Hits                     43303    43301       -2     
- Misses                   19227    19259      +32     
+ Partials                  2618     2596      -22     
Flag Coverage Δ
Linux_ 66.04% <5.88%> (-0.01%) ⬇️
_1 34.82% <0.00%> (ø)
_2 55.41% <0.00%> (?)
_3 44.58% <0.00%> (-0.01%) ⬇️
_4 34.88% <5.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lic/components/getting_started/getting_started.tsx 85.71% <ø> (ø)
...ment_section/objects_table/saved_objects_table.tsx 67.98% <100.00%> (ø)
...on/index_patterns/index_patterns/index_patterns.ts 56.33% <0.00%> (ø)
...ugins/data/public/search/errors/painless_error.tsx 50.00% <0.00%> (ø)
...lugins/data/server/saved_objects/index_patterns.ts 25.00% <0.00%> (ø)
...terns/index_patterns/redirect_no_index_pattern.tsx 6.66% <0.00%> (ø)
.../plugins/index_pattern_management/public/plugin.ts 7.14% <0.00%> (-2.86%) ⬇️

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hailong-am Hailong-am changed the title App category changes App category changes - (Index pattern) Sep 21, 2023
* move index pattern to libaray

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Remove it from Dashboards management when workspace is on

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>

index pattern always show under library

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am force-pushed the app_navigation_changes branch from 35a1129 to 8a32ab5 Compare September 28, 2023 03:03
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am marked this pull request as ready for review September 28, 2023 07:57
@Hailong-am Hailong-am closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants