Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed UT for index pattern and retire dashboard management #188

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Sep 20, 2023

Description

  1. Fix failed UT for retire dashboards management
  2. Fix missed index pattern path change

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #188 (ba4e180) into workspace (33e90ec) will decrease coverage by 5.38%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           workspace     #188      +/-   ##
=============================================
- Coverage      60.58%   55.20%   -5.38%     
=============================================
  Files           2992     3131     +139     
  Lines          58610    61766    +3156     
  Branches        9531     9976     +445     
=============================================
- Hits           35508    34101    -1407     
- Misses         21015    25591    +4576     
+ Partials        2087     2074      -13     
Flag Coverage Δ
Linux_1 30.41% <0.00%> (ø)
Linux_2 ?
Linux_3 42.75% <0.00%> (-0.01%) ⬇️
Linux_4 34.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ugins/data/public/search/errors/painless_error.tsx 50.00% <0.00%> (ø)

... and 1365 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hailong-am Hailong-am merged commit a2abcf2 into ruanyl:workspace Sep 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants