Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reserved workspace customization #202

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: reserved workspace customization #202

merged 2 commits into from
Sep 25, 2023

Conversation

yuye-aws
Copy link
Collaborator

@yuye-aws yuye-aws commented Sep 25, 2023

Description

  1. Hide delete button for reserved workspace in workspace update page
  2. For update workspace API, reserved workspace name cannot be changes

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yuye-aws yuye-aws changed the base branch from main to workspace September 25, 2023 07:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #202 (af6e0ee) into workspace (a2abcf2) will decrease coverage by 7.84%.
Report is 3 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #202      +/-   ##
=============================================
- Coverage      66.09%   58.26%   -7.84%     
=============================================
  Files           3420     3003     -417     
  Lines          65752    57666    -8086     
  Branches       10589     8917    -1672     
=============================================
- Hits           43461    33601    -9860     
- Misses         19650    22177    +2527     
+ Partials        2641     1888     -753     
Flag Coverage Δ
Linux_1 30.41% <ø> (ø)
Linux_2 55.05% <ø> (ø)
Linux_3 ?
Linux_4 34.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 811 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
@yuye-aws yuye-aws merged commit 03b2452 into ruanyl:workspace Sep 25, 2023
20 checks passed
@yuye-aws yuye-aws deleted the reserved_customization branch October 19, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants