Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary workspace menu register #204

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Sep 26, 2023

Description

@SuZhou-Joe had a good suggestion to move the workspace menu render from core workspace service module to chrome service, this PR is about to remove it from core workspace service

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #204 (e16a76c) into workspace-pr-integr (8f68914) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #204      +/-   ##
=======================================================
- Coverage                66.47%   66.17%   -0.31%     
=======================================================
  Files                     3408     3384      -24     
  Lines                    65155    64831     -324     
  Branches                 10431    10430       -1     
=======================================================
- Hits                     43309    42899     -410     
- Misses                   19250    19399     +149     
+ Partials                  2596     2533      -63     
Flag Coverage Δ
Linux_ 66.05% <100.00%> (?)
_1 ?
_2 ?
_3 44.58% <0.00%> (+<0.01%) ⬆️
_4 34.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/public/core_system.ts 91.95% <100.00%> (ø)
...c/core/public/workspace/workspaces_service.mock.ts 100.00% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 90.00% <100.00%> (-6.30%) ⬇️

... and 83 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanyl ruanyl merged commit 5bc2ddf into workspace-pr-integr Sep 27, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants