Add integration test for workspace saved objects client wrapper #206
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov Report
@@ Coverage Diff @@
## workspace #206 +/- ##
==============================================
+ Coverage 30.42% 66.21% +35.79%
==============================================
Files 2199 3420 +1221
Lines 45154 65755 +20601
Branches 7023 10589 +3566
==============================================
+ Hits 13737 43541 +29804
+ Misses 30810 19571 -11239
- Partials 607 2643 +2036
Flags with carried forward coverage won't be shown. Click here to find out more. see 2212 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Lin Wang <wonglam@amazon.com>
…ear all Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
| @@ -145,7 +145,7 @@ function getClauseForWorkspace(workspace: string) { | |||
|
|
|||
| return { | |||
| bool: { | |||
| must: [{ term: { workspaces: workspace } }], | |||
| must: [{ term: { 'workspaces.keyword': workspace } }], | |||
There was a problem hiding this comment.
the type of workspaces is keyword, do we need keyword here?
There was a problem hiding this comment.
The integration tests in linux will be failed, if we don't add the .keyword suffix.
There was a problem hiding this comment.
You can create .kibana index first with pre-defined mappings, otherwise openSearch will set the type automatically. the default type for string is text with sub field keyword, that's the case you have mentioned.
There was a problem hiding this comment.
Is there anyway to define this type in the saved objects side? It seems the workspaces field will be text type if mapping not defined. It could be a bug because we can't create .kibana index with pre-defined mapping when create saved objects in the real server.
There was a problem hiding this comment.
how about doing this in beforeAll method, you can replace mappings with real .kibana mappings
await opensearchServer.opensearch.getClient().indices.create({
body: { mappings, settings },
index,
});
There was a problem hiding this comment.
This only worked for integration tests right? Will we have the same problems in the real case?
There was a problem hiding this comment.
No, IndexMigrator will create .kibana with expected mapping when OSD startup. Test server disabled the migration with https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/test_helpers/osd_server.ts#L63.
with this, you may override the setting for test server to enable migration .
There was a problem hiding this comment.
Fixed, feel free to help me re-review it.
...kspace/server/saved_objects/integration_tests/workspace_saved_objects_client_wrapper.test.ts
Show resolved
Hide resolved
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Description
addToWorkspacesanddeleteByWorkspacein client wrapperIssues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr