[Workspace][Feature] Import sample data to workspace #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
* refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
wanglam
changed the title
wanglam
changed the title
Codecov Report
@@ Coverage Diff @@
## workspace-pr-integr #210 +/- ##
=======================================================
+ Coverage 66.46% 66.49% +0.02%
=======================================================
Files 3408 3412 +4
Lines 65222 65253 +31
Branches 10457 10460 +3
=======================================================
+ Hits 43353 43390 +37
+ Misses 19265 19263 -2
+ Partials 2604 2600 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SuZhou-Joe
reviewed
Oct 11, 2023
| savedObjectList: SavedObject[], | ||
| workspaceId?: string | ||
| ) => { | ||
| savedObjectList = cloneDeep(savedObjectList); |
There was a problem hiding this comment.
I am a little bit confused here, should we assign the copied object to a new variable?
There was a problem hiding this comment.
There are too many attributes update work in overrideSavedObjectId. It's all based references, it will take huge effects if we want to use new variables.
There was a problem hiding this comment.
I guess @SuZhou-Joe want to say: shall we do const savedObjectListCopy = cloneDeep(savedObjectList);?
SuZhou-Joe
reviewed
Oct 11, 2023
Comment on lines
+88
to
+93
| if (workspaceId) { | ||
| savedObjectsList = getWorkspaceIntegratedSavedObjects(savedObjectsList, workspaceId); | ||
| } | ||
| if (dataSourceId) { | ||
| savedObjectsList = getDataSourceIntegratedSavedObjects(savedObjectsList, dataSourceId); | ||
| } |
There was a problem hiding this comment.
Should we take the order of these two ifs into account?
There was a problem hiding this comment.
Yes, it will cause different id after condition switched.
ruanyl
approved these changes
Oct 12, 2023
| savedObjectList: SavedObject[], | ||
| workspaceId?: string | ||
| ) => { | ||
| savedObjectList = cloneDeep(savedObjectList); |
There was a problem hiding this comment.
I guess @SuZhou-Joe want to say: shall we do const savedObjectListCopy = cloneDeep(savedObjectList);?
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
approved these changes
Oct 13, 2023
|
Shall we add some integration_test for the functionality? |
8 tasks
wanglam
added a commit
that referenced
this pull request
Feb 26, 2024
* feat: import sample data saved objects to workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: simplify sample data saved object id prefix logic (#1) * refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * refactor: assigned copied saved objects to new variables Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Mar 18, 2024
* feat: import sample data saved objects to workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: simplify sample data saved object id prefix logic (#1) * refactor: simplify sample data saved object id prefix logic Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: align the prefix order of sample data install and uninstall rename appendPrefix to addPrefix Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * refactor: assigned copied saved objects to new variables Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import sample data to specific workspace
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr