[Workspace]Add workspace id in basePath

[SuZhou-Joe]

Description

Issues Resolved

Screenshot

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #212 (2c79849) into workspace-pr-integr (903e594) will decrease coverage by 4.44%.
Report is 1 commits behind head on workspace-pr-integr.
The diff coverage is 82.96%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #212      +/-   ##
=======================================================
- Coverage                66.06%   61.62%   -4.44%     
=======================================================
  Files                     3386     2981     -405     
  Lines                    64872    57676    -7196     
  Branches                 10455     9314    -1141     
=======================================================
- Hits                     42858    35545    -7313     
- Misses                   19446    20039     +593     
+ Partials                  2568     2092     -476     

Flag	Coverage Δ
Linux_	?
_1	34.95% <71.11%> (?)
_2	55.51% <97.61%> (+0.05%)	⬆️
_3	44.50% <40.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/core/public/http/http_service.mock.ts	100.00% <100.00%> (ø)
src/core/public/http/http_service.ts	88.23% <100.00%> (+3.61%)	⬆️
src/core/utils/constants.ts	100.00% <100.00%> (ø)
src/core/utils/workspace.ts	100.00% <100.00%> (ø)
src/plugins/workspace/common/constants.ts	100.00% <100.00%> (ø)
...ts/workspace_fatal_error/workspace_fatal_error.tsx	100.00% <100.00%> (ø)
.../plugins/workspace/public/workspace_client.mock.ts	100.00% <100.00%> (ø)
src/core/public/http/base_path.ts	95.83% <93.75%> (+7.59%)	⬆️
src/plugins/workspace/public/plugin.ts	73.07% <75.00%> (ø)
src/plugins/workspace/public/workspace_client.ts	71.92% <71.92%> (ø)

... and 757 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ruanyl]

Nit, just another thought, instead of calling formatUrlWithWorkspaceId, perhaps we can refactor getUrlForApp like this:

getUrlForApp: (appId, {path, absolute = false, withoutWorkspace = false}) => ...

[SuZhou-Joe]

Actually I do not know if we should do that as I think getUrlForApp is a method to handle path without knowing basePath, though under the hood it uses bathPath.prepend to format url.

[ruanyl]

I see, that makes sense

[opensearch-workspace-development]

The backport to workspace failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace workspace
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace
# Create a new branch
git switch --create backport/backport-212-to-workspace
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 43e91faec7ab11131207f598668b073f727ef073
# Push it to GitHub
git push --set-upstream origin backport/backport-212-to-workspace
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace

Then, create a pull request where the base branch is workspace and the compare/head branch is backport/backport-212-to-workspace.