Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy saved objects API #217

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Oct 10, 2023

Description

Add copy saved objects API and add some integration tests.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: gaobinlong <gbinlong@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #217 (9bb5e05) into workspace-pr-integr (87c0c8a) will decrease coverage by 0.02%.
The diff coverage is 26.66%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #217      +/-   ##
=======================================================
- Coverage                66.48%   66.47%   -0.02%     
=======================================================
  Files                     3412     3413       +1     
  Lines                    65234    65249      +15     
  Branches                 10456    10457       +1     
=======================================================
+ Hits                     43370    43372       +2     
- Misses                   19260    19272      +12     
- Partials                  2604     2605       +1     
Flag Coverage Δ
_1 34.82% <ø> (ø)
_2 55.43% <26.66%> (-0.02%) ⬇️
_3 44.48% <6.66%> (-0.03%) ⬇️
_4 34.83% <6.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/server/saved_objects/routes/index.ts 100.00% <100.00%> (ø)
src/core/server/saved_objects/routes/copy.ts 21.42% <21.42%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gaobinlong gaobinlong merged commit 4217efa into ruanyl:workspace-pr-integr Oct 19, 2023
32 checks passed
wanglam pushed a commit that referenced this pull request Feb 26, 2024
* Add copy saved objects API

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Modify file header

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
* Add copy saved objects API

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Modify file header

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants