Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create and bulkCreate override with target workspaces #218

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Oct 11, 2023

Description

Fix create and bulkCreate can't override with permitted target workspaces

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…workspaces

Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #218 (6ff9d5a) into workspace (5a26f70) will decrease coverage by 0.01%.
Report is 2 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #218      +/-   ##
=============================================
- Coverage      66.21%   66.20%   -0.01%     
=============================================
  Files           3420     3419       -1     
  Lines          65755    65753       -2     
  Branches       10589    10590       +1     
=============================================
- Hits           43541    43535       -6     
- Misses         19571    19574       +3     
- Partials        2643     2644       +1     
Flag Coverage Δ
Linux_1 30.42% <ø> (+<0.01%) ⬆️
Linux_2 55.36% <ø> (-0.03%) ⬇️
Linux_3 42.76% <ø> (+<0.01%) ⬆️
Linux_4 34.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wanglam wanglam marked this pull request as ready for review October 11, 2023 05:15
@wanglam wanglam merged commit b22111a into ruanyl:workspace Oct 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants