Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigate to create workspace/workspaces list page without refreshing #220

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Oct 11, 2023

Description

currently, navigate to "Create workspace" page and "All workspace" list page from workspace context menu triggers a full page reload which is unnecessary.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #220 (94c3f94) into workspace (2771ff9) will increase coverage by 0.00%.
Report is 1 commits behind head on workspace.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           workspace     #220   +/-   ##
==========================================
  Coverage      66.20%   66.21%           
==========================================
  Files           3419     3419           
  Lines          65753    65753           
  Branches       10590    10590           
==========================================
+ Hits           43535    43537    +2     
+ Misses         19574    19573    -1     
+ Partials        2644     2643    -1     
Flag Coverage Δ
Linux_1 30.42% <ø> (ø)
Linux_2 55.36% <ø> (ø)
Linux_3 42.77% <ø> (+<0.01%) ⬆️
Linux_4 34.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/public/chrome/chrome_service.tsx 86.66% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanyl ruanyl merged commit a74a6ee into workspace Oct 12, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants