Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace][Workspace]Add workspace id in basePath (#212) #225

Merged

Conversation

SuZhou-Joe
Copy link
Collaborator

  • feat: enable workspace id in basePath

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: add unit test

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: remove useless test object id

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: add unit test

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: add unit test

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: update snapshot

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: move formatUrlWithWorkspaceId to core/public/utils

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: remove useless variable

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: remove useless variable

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: optimization

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: optimization

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: optimization

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: move workspace/utils to core

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: move workspace/utils to core

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: update comment

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: optimize code

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: update unit test

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: optimization

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: add space under license

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • fix: unit test

Signed-off-by: SuZhou-Joe suzhou@amazon.com


Signed-off-by: SuZhou-Joe suzhou@amazon.com
(cherry picked from commit 43e91fa)

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe marked this pull request as draft October 12, 2023 10:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #225 (82222e3) into workspace (2964934) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           workspace     #225      +/-   ##
=============================================
- Coverage      66.21%   66.19%   -0.03%     
=============================================
  Files           3422     3431       +9     
  Lines          65748    65952     +204     
  Branches       10587    10616      +29     
=============================================
+ Hits           43538    43658     +120     
- Misses         19566    19646      +80     
- Partials        2644     2648       +4     
Flag Coverage Δ
Linux_1 30.56% <83.33%> (+0.13%) ⬆️
Linux_2 55.41% <100.00%> (+0.05%) ⬆️
Linux_3 42.77% <38.09%> (-0.01%) ⬇️
Linux_4 34.52% <19.04%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/public/http/http_service.mock.ts 100.00% <100.00%> (ø)
src/core/utils/workspace.ts 100.00% <100.00%> (ø)
...ment_section/objects_table/saved_objects_table.tsx 57.24% <ø> (+0.21%) ⬆️
...ts/workspace_fatal_error/workspace_fatal_error.tsx 100.00% <ø> (ø)
...ublic/components/workspace_menu/workspace_menu.tsx 2.70% <ø> (ø)
src/plugins/workspace/public/utils.ts 100.00% <ø> (+33.33%) ⬆️
.../plugins/workspace/public/workspace_client.mock.ts 100.00% <100.00%> (ø)
src/plugins/workspace/public/workspace_client.ts 71.42% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SuZhou-Joe SuZhou-Joe marked this pull request as ready for review October 13, 2023 03:42
* feat: enable workspace id in basePath

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove useless test object id

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: move formatUrlWithWorkspaceId to core/public/utils

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove useless variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove useless variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimization

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimization

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimization

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: move workspace/utils to core

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: move workspace/utils to core

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimization

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add space under license

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 43e91fa)
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-212-to-workspace branch from f9ccede to 82222e3 Compare October 16, 2023 03:18
@SuZhou-Joe SuZhou-Joe merged commit 9b8bdf6 into ruanyl:workspace Oct 16, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants