forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport workspace][Workspace]Add workspace id in basePath (#212) #225
Merged
SuZhou-Joe
merged 6 commits into
ruanyl:workspace
from
SuZhou-Joe:backport/backport-212-to-workspace
Oct 16, 2023
Merged
[Backport workspace][Workspace]Add workspace id in basePath (#212) #225
SuZhou-Joe
merged 6 commits into
ruanyl:workspace
from
SuZhou-Joe:backport/backport-212-to-workspace
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #225 +/- ##
=============================================
- Coverage 66.21% 66.19% -0.03%
=============================================
Files 3422 3431 +9
Lines 65748 65952 +204
Branches 10587 10616 +29
=============================================
+ Hits 43538 43658 +120
- Misses 19566 19646 +80
- Partials 2644 2648 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanyl
approved these changes
Oct 16, 2023
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 43e91fa)
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
backport/backport-212-to-workspace
branch
from
October 16, 2023 03:18
f9ccede
to
82222e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
Signed-off-by: SuZhou-Joe suzhou@amazon.com
(cherry picked from commit 43e91fa)
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr