Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace]Add unit test for delete saved objects by workspace #229

Conversation

Hailong-am
Copy link
Collaborator

Description

Backport delete saved objects by workspace unit test cases into workspace branch

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #229 (84f05e2) into workspace (2964934) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           workspace     #229   +/-   ##
==========================================
  Coverage      66.21%   66.22%           
==========================================
  Files           3422     3422           
  Lines          65748    65748           
  Branches       10587    10587           
==========================================
+ Hits           43538    43539    +1     
+ Misses         19566    19565    -1     
  Partials        2644     2644           
Flag Coverage Δ
Linux_1 30.42% <ø> (ø)
Linux_2 55.36% <ø> (+<0.01%) ⬆️
Linux_3 42.78% <ø> (ø)
Linux_4 34.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ore/server/saved_objects/service/lib/repository.ts 89.43% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hailong-am Hailong-am merged commit 7a72a73 into ruanyl:workspace Oct 16, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants