-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: create management / public workspaces when calling list api #236
Feature: create management / public workspaces when calling list api #236
Conversation
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Codecov Report
@@ Coverage Diff @@
## workspace-pr-integr #236 +/- ##
=======================================================
- Coverage 66.55% 66.55% -0.01%
=======================================================
Files 3419 3420 +1
Lines 65439 65458 +19
Branches 10507 10508 +1
=======================================================
+ Hits 43555 43563 +8
- Misses 19270 19281 +11
Partials 2614 2614
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Approved, actually myself still not fully convinced by the current implementation, but I believe this is the best we can do at the moment. Having the default workspace(management, public, personal) initialization logic in the I'm thinking if we can overcome this by fine-tuning the UX? For example, we could have a workspace onboarding page which let the user to choose if they want to enabled |
Totally agreed. |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace workspace
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace
# Create a new branch
git switch --create backport/backport-236-to-workspace
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ff9e8839813b701057b4c76269f35943944fdab
# Push it to GitHub
git push --set-upstream origin backport/backport-236-to-workspace
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace Then, create a pull request where the |
…236) * feat: create management / public workspaces when calling list api Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: integration test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: flaky test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…236) * feat: create management / public workspaces when calling list api Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: integration test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: flaky test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr